Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for China Region #40

Closed
neptune19821220 opened this issue Apr 26, 2020 · 3 comments · Fixed by #41
Closed

Please add support for China Region #40

neptune19821220 opened this issue Apr 26, 2020 · 3 comments · Fixed by #41
Labels
enhancement New feature or request
Milestone

Comments

@neptune19821220
Copy link

Dear Developer:

I find your Athena driver doesn't support China Region due to the endpoint difference.
For Athena endpoint list : https://docs.aws.amazon.com/general/latest/gr/athena.html
The China regions all ends with amazonaws.com.cn instead amazonaws.com.

And the config document , https://s3.amazonaws.com/athena-downloads/drivers/JDBC/SimbaAthenaJDBC_2.0.9/docs/Simba+Athena+JDBC+Driver+Install+and+Configuration+Guide.pdf , the EndpointOverride config seems not change the suffix of the endpoint.

Thanks.

@dacort
Copy link
Owner

dacort commented Apr 26, 2020

Hi @neptune19821220 - thanks for filing the new issue re: China support!

I'll just have to make a small change in the code to support this. Currently it's hardcoded to amazonaws.com.

I should be able to have a fix for this within a week or so.

@dacort dacort added the enhancement New feature or request label Apr 26, 2020
@dacort dacort added this to the v1.1.0 milestone Jul 30, 2020
@dacort dacort closed this as completed in #41 Aug 2, 2020
@hbuzhuhaoju
Copy link

I used your latest Athena driver ,v1.10, but driver also throw exception for China region;

An error has been thrown from the AWS SDK client. Unable to execute HTTP request: athena.cn-north-1.amazonaws.com: Name or service not known [Execution ID not available]

Please forgive my bad english

@hbuzhuhaoju
Copy link

@dacort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants