Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift restrictions for Scope disposal when using ambient ScopeContext #168

Closed
dadhi opened this issue Aug 22, 2019 · 1 comment
Closed

Lift restrictions for Scope disposal when using ambient ScopeContext #168

dadhi opened this issue Aug 22, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dadhi
Copy link
Owner

dadhi commented Aug 22, 2019

The restriction is checking if container scope is the same as the current ambient scope from the context, and only then disposing it - otherwise not.

Now I am disposing current ambient scope without any checks - anyway ambient scopes could be changed any time not depending on container.

This may provide more predictability for AsyncExecutionFlowScopeContext and ThreadScopeContext.

@dadhi dadhi added the enhancement New feature or request label Aug 22, 2019
@dadhi dadhi added this to the v4.1.0 milestone Aug 22, 2019
@dadhi dadhi self-assigned this Aug 22, 2019
@dadhi
Copy link
Owner Author

dadhi commented Aug 22, 2019

fixed

@dadhi dadhi closed this as completed Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant