-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Configuration of signer
moved into jwt
finalizer
#1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proper management of keys and certificates
jwt
finalizersigner
moved into jwt
finalizer
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 89.58% 89.63% +0.04%
==========================================
Files 271 272 +1
Lines 9084 9012 -72
==========================================
- Hits 8138 8078 -60
+ Misses 702 696 -6
+ Partials 244 238 -6 ☔ View full report in Codecov by Sentry. |
…ore. To be updated after running the actual demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
relates to #1493
relates to #1507
closes #1536
Checklist
Description
Until #1493, there was just a single mechanism, which was making use of key material for signature creation purposes - the
jwt
finalizer. With that FR the situation has changed and there is a need to have independent key material configurations for different mechanisms.This requirement has been addressed by this PR, which refactors the existing configuration (which introduces a breaking change) and makes it more future proof.
Old Configuraiton & Behavior
Before this PR, heimdall generated an ECDSA key pair if the global
signer
property was not configured. Thejwt
fnalizer did then make use of it.New Configuration & Behavior
This PR has moved the configuration of the signer into the
jwt
finalizer and made the configuration of the corresponding key material mandatory.The configured key material is still exposed via the JWKS endpoint as it was previously the case. The behavior related to certificate expiration metrics is preserved as well.
Other topics
This PR fixes the #1536 bug as well
BEGIN_COMMIT_OVERRIDE
refactor!: Configuration of
signer
moved intojwt
finalizer (#1534)fix: Taking updates of certificates into account while collecting metrics (#1534)
END_COMMIT_OVERRIDE