Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Deprecated OTEL attributes replaced #1669

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Jul 26, 2024

Related issue(s)

OTEL has deprecated some of the attributes used so far in exposed metrics/traces. See also HTTP semantic conventions declared stable and Network Deprecated Attributes

Description

This PR updates the code to

  • use semconv 1.26.0,
  • use client.address instead of the deprecated net.peer.name,
  • use client.port instead of the deprecated net.peer.port,
  • use server.address instead of the deprecated net.host.name,
  • use server.port instead of the deprecated net.host.port,
  • use network.peer.address instead of the deprecated net.sock.peer.addr,
  • use network.peer.port instead of the deprecated net.sock.peer.port,
  • use network.protocol.name and network.protocol.version instead of the deprecated http.flavor,
  • use http.request.method instead of the deprecated http.method,
  • use url.scheme instead of the deprecated http.scheme.

dadrus added 2 commits July 26, 2024 10:02
…ributes in OTEL metrics anymore, client.address and client.port are now used instead
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (9ade970) to head (6998843).
Report is 1 commits behind head on main.

Files Patch % Lines
...handler/middleware/grpc/otelmetrics/interceptor.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
+ Coverage   89.59%   89.68%   +0.08%     
==========================================
  Files         271      271              
  Lines        9006     8993      -13     
==========================================
- Hits         8069     8065       -4     
+ Misses        697      690       -7     
+ Partials      240      238       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dadrus dadrus changed the title refactor!: Deprecated OTEL attributes replaced with new ones refactor!: Deprecated OTEL attributes replaced Jul 26, 2024
@dadrus dadrus merged commit e5ed3a5 into main Jul 26, 2024
27 checks passed
@dadrus dadrus deleted the refactor/otel_semver branch July 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant