Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve previewer navigation #181

Merged
merged 2 commits into from
Mar 26, 2017

Conversation

glutanimate
Copy link
Contributor

This commit addresses a few things in the card previewer which I think might count as inconsistencies.

In particular, the commit changes the following behaviour, as present in the current previewer:

  1. When a single card is shown, pressing either the "previous" or "next" button will result in both buttons being disabled
  2. When the first card is active and set to the question side, the "previous" button can be pressed despite there being nothing to move back to
  3. With the question side active, hitting "previous" will show the answer to that card
  4. With the answer side active, hitting "previous" will show the question side of the last card

The updated behaviour in each of these cases looks like this:

  1. If on the question side, show "next" button. If on the answer side, show "previous" button
  2. Don't show "previous" button on the question side
  3. Hitting "previous" while the question side is visible will move the previewer to the question side of the last card
  4. Hitting "previous" while the answer side is active will move the previewer back to the question side of that card

I think this behaviour is more in line with what a user might expect when first using the previewer, but there might be a use case I'm not seeing here. If that's the case, please let me know and I'll see if I can come up with something different.

@dae dae merged commit 783767b into ankitects:master Mar 26, 2017
@dae
Copy link
Member

dae commented Mar 26, 2017

thanks

@glutanimate glutanimate deleted the fix-previewer-navigation branch August 25, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants