Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xUnit lit test runner doesn't work on Windows #1538

Closed
robin-aws opened this issue Oct 25, 2021 · 0 comments · Fixed by #1540
Closed

xUnit lit test runner doesn't work on Windows #1538

robin-aws opened this issue Oct 25, 2021 · 0 comments · Fixed by #1540
Assignees
@robin-aws
Labels
kind: bug Crashes, unsoundness, incorrect output, etc. If possible, add a `part:` label platform: windows Windows-specific issues

Comments

@robin-aws
Copy link
Member

Hidden regression from #680, since the CI is not running the integration tests on windows (#1313). I defined %diff as just diff, which works on Linux and OSX but not Windows.

I already had an alternative implemented using DiffPlex, but I didn't use it in #680 only because it needed a bit of tweaking to interact correctly with XFAIL tests.
@robin-aws robin-aws added kind: bug Crashes, unsoundness, incorrect output, etc. If possible, add a `part:` label platform: windows Windows-specific issues labels Oct 25, 2021
@robin-aws robin-aws self-assigned this Oct 25, 2021
@robin-aws robin-aws mentioned this issue Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robin-aws robin-aws

Labels
kind: bug Crashes, unsoundness, incorrect output, etc. If possible, add a `part:` label platform: windows Windows-specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

In-memory implementation of %diff, enable integration tests on windows robin-aws/dafny
1 participant
@robin-aws