Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect MFA Detection in MFASweep #19

Open
LuxNoBulIshit opened this issue Nov 27, 2024 · 0 comments
Open

Incorrect MFA Detection in MFASweep #19

LuxNoBulIshit opened this issue Nov 27, 2024 · 0 comments

Comments

@LuxNoBulIshit
Copy link

Issue: Incorrect MFA Detection in MFASweep
Description:
The MFASweep script incorrectly identifies certain responses as "no MFA required," even when MFA is indeed required. The logic currently checks for specific strings (authMethodId, Stay signed in, or Verify your identity) in $AuthRequest.Content. If none of these strings match, the script concludes that MFA is not required. However, this does not account for cases where MFA is requested in different forms or through redirection pages.

Reproduction Steps:
Run MFASweep against an account with MFA enabled.
Observe the response content. For example:
html
Copy code

<title>Working...</title>

Script is disabled. Click Submit to continue.

<script language="javascript" nonce='...'>document.forms[0].submit();</script> The script incorrectly concludes: "It appears there is no MFA required for this account". Expected Behavior: The script should detect that MFA is required based on the presence of certain hidden input fields (e.g., request, flowToken, canary) or the presence of redirection via JavaScript.

Actual Behavior:
The script outputs: "It appears there is no MFA required for this account."

Suggested Fix:
Expand the detection logic to include cases like redirection pages and hidden form inputs (e.g., request, flowToken, canary). This will ensure that MFASweep accurately detects when MFA is required.

Additional Notes:
The issue occurs with MFA challenges that use redirection or hidden forms instead of the typical methods (authMethodId, etc.).
Please let me know if you need more information or test cases to validate the fix.
Thank you for your great work on MFASweep! I hope this feedback helps improve the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant