Azure CLI replaces VSTS CLI

[pinkfloydx33]

The VSTS CLI has been deprecated and replaced with the Azure CLI (az repos).

The aliases that are added via --use-git-aliases are the same as the Vsts ones, pr being the primary one. Would need to add a new known alias to support both Vsts and az. Additionally, some of the sub-commands have changed; many of them are pluralization (reviewer vs reviewers) but some options have been removed and a few added.

Any chance the module will be updated to officially support the aliases added by the Azure CLI?

I've updated my local copy of the module and would gladly submit a PR if you'd like.

[dahlbyk]

I've updated my local copy of the module and would gladly submit a PR if you'd like.

That would be great!

Is it reasonable to retain support for vsts and add parallel support for az devops aliases?

[pinkfloydx33]

Yes we can support both aliases. I had to make a few tweaks to my local after you said that, but its easily done. The alias contents are different so we can key off KnownAliases and it works fine. You'll never have both installed, but if you did for some reason they shouldn't conflict.

I also added support for those commands that have sub-commands; for example git pr policy list - -params with policy having sub-commands (list, etc). There are a few others: reviewers and work-items. I did not back-port that to the Vsts version however, so azure cli only.

I'll have a PR likely later today. I've also added support for #691. Should I submit two seperate PRs?

[dahlbyk]

Should I submit two seperate PRs?

Definitely separate commits, but a single PR is fine.

[pinkfloydx33]

Working on writing some tests to include in the PR. I've noticed that (even on master) several of the test fail, specifically those using $result | Should -Be @() . Even a simple test of @() | Should Be @() fails. I was able to fix these by changing to $result | Should BeNullOrEmpty but I'm not sure if this is just me/if I'm doing something wrong.