Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a nicer error message for non-str markers #34

Closed
trag1c opened this issue Jun 5, 2024 · 1 comment · Fixed by #36
Closed

Add a nicer error message for non-str markers #34

trag1c opened this issue Jun 5, 2024 · 1 comment · Fixed by #36
Labels
good first issue Good for newcomers improvement Code/documentation/DX improvements

Comments

@trag1c
Copy link
Member

trag1c commented Jun 5, 2024

Dahlia(marker=[1]) currently raises TypeError: can only concatenate list (not "str") to list.
I feel like one should expect to see TypeError: the marker has to be a string
@trag1c trag1c added good first issue Good for newcomers improvement Code/documentation/DX improvements labels Jun 5, 2024
@trag1c
Copy link
Member Author

trag1c commented Jun 6, 2024

Resolved by #36

@trag1c trag1c closed this as completed Jun 6, 2024
@trag1c trag1c linked a pull request Jun 6, 2024 that will close this issue
Nonstring marker handling #36
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Code/documentation/DX improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nonstring marker handling cadaniel02/dahlia
1 participant
@trag1c