Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres.js does not correctly parse URLs containing unix sockets #56

Open
honnip opened this issue Oct 31, 2024 · 6 comments
Open

postgres.js does not correctly parse URLs containing unix sockets #56

honnip opened this issue Oct 31, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@honnip
Copy link
Contributor

honnip commented Oct 31, 2024

Related:

The library does not correctly parse URLs containing unix sockets.

I confirmed that porsager/postgres#484 (comment) solves it. (https://github.com/honnip/hollo/commits/db/unix-socket/)

@honnip honnip changed the title postgres.js does not parse the database url correctly postgres.js does not correctly parse URLs containing unix sockets Oct 31, 2024
@dahlia dahlia added the bug Something isn't working label Oct 31, 2024
@ThisIsMissEm
Copy link
Contributor

@dahlia is there a reason we're using postgres instead of pg?

@dahlia
Copy link
Owner

dahlia commented Oct 31, 2024

@ThisIsMissEm It's because @fedify/postgres depends on postgres.js.

@ThisIsMissEm
Copy link
Contributor

Could @fedify/postgres depend on pg instead?

@dahlia
Copy link
Owner

dahlia commented Nov 1, 2024

It can switch over to pg if pg supports NOTIFY/LISTEN. However, I think it will require a whole rewrite. 🤔

@ThisIsMissEm
Copy link
Contributor

Ah, ick, okay. I can't recall if pg does explicitly support those but I think so?

@dahlia
Copy link
Owner

dahlia commented Nov 1, 2024

Maybe it would be better to create a separate package called @fedify/pg. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants