Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate % not working in C# #23

Open
jonathanmccracken opened this issue Aug 4, 2016 · 1 comment
Open

Duplicate % not working in C# #23

jonathanmccracken opened this issue Aug 4, 2016 · 1 comment
Assignees
Labels

Comments

@jonathanmccracken
Copy link
Contributor

Description

Sometimes the duplicates in C# are way over 100% because cpd doesn't exclude the ignored assemblies/directories.

Steps to Reproduce

  1. Run a c# project
  2. Ignore some assemblies that have large subdirectories of source code
  3. Watch duplicates go way off the charts

Metropolis Version: 0.0.68
Operating System (i.e. Windows) Version: Windows 10

@jonathanmccracken
Copy link
Contributor Author

jonathanmccracken commented Aug 4, 2016

Try to expand Greg's .ignore file to include directories
modify cpd to use:
--exclude Files to be excluded from CPD check
https://pmd.github.io/pmd-5.4.1/usage/cpd-usage.html

Supports directories apparently...
https://github.com/pmd/pmd/blob/master/pmd-core/src/main/java/net/sourceforge/pmd/cpd/CPDConfiguration.java#L296

Potentially add C#'s '--ignore-usings' since we don't want to report duplicate using blocks in our numbers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant