Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] send image in chat #81

Closed
dai-shi opened this issue Apr 29, 2020 · 2 comments · Fixed by #107
Closed

[feature] send image in chat #81

dai-shi opened this issue Apr 29, 2020 · 2 comments · Fixed by #107
Labels
enhancement New feature or request Size M Medium size web app For src/web

Comments

@dai-shi
Copy link
Owner

dai-shi commented Apr 29, 2020

Preferably, by pasting an image from the OS clipboard.
@dai-shi dai-shi added enhancement New feature or request web app For src/web Size M Medium size labels Apr 29, 2020
@dai-shi
Copy link
Owner Author

dai-shi commented May 2, 2020

https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Using_data_channels

Currently, it's not practical to use RTCDataChannel for messages larger than 64kiB (16kiB if you want to support cross-browser exchange of data).

We need to resize image in advance.

@dai-shi dai-shi added Size L Large size and removed Size M Medium size labels May 2, 2020
@dai-shi
Copy link
Owner Author

dai-shi commented May 15, 2020

PeerJS seems to have the capability to cut big data into chunks, so hopefully we don't need to resize it.

@dai-shi dai-shi added Size M Medium size and removed Size L Large size labels May 15, 2020
@dai-shi dai-shi mentioned this issue May 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Size M Medium size web app For src/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: wysiwyg editor dai-shi/remote-faces
1 participant
@dai-shi