Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple_market synchronized modifier and affected methods should be updated before a new release #179

Open
brianmcmichael opened this issue Oct 24, 2019 · 0 comments

Comments

@brianmcmichael
Copy link

The synchronized pattern in simple_market.sol follows an old reentrancy guard pattern that should be updated prior to another release.

The issue was first described in OpenZeppelin/openzeppelin-contracts#335 where a developer could inadvertently create a situation where the contract enters a locked state.

It seems that this may not be a major issue for 0.4+ versions of solidity, but it looks like an alternate pattern without a locking mechanism is recommended at https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/ReentrancyGuard.sol.

Probably a low-priority issue, but worth adding if a new version is deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant