You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The synchronized pattern in simple_market.sol follows an old reentrancy guard pattern that should be updated prior to another release.
The issue was first described in OpenZeppelin/openzeppelin-contracts#335 where a developer could inadvertently create a situation where the contract enters a locked state.
The
synchronized
pattern insimple_market.sol
follows an old reentrancy guard pattern that should be updated prior to another release.The issue was first described in OpenZeppelin/openzeppelin-contracts#335 where a developer could inadvertently create a situation where the contract enters a locked state.
It seems that this may not be a major issue for 0.4+ versions of solidity, but it looks like an alternate pattern without a locking mechanism is recommended at https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/ReentrancyGuard.sol.
Probably a low-priority issue, but worth adding if a new version is deployed.
The text was updated successfully, but these errors were encountered: