Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find/Replace dialog UI arrangement issues for Mac Version #535

Closed
ErickWei opened this issue Apr 1, 2024 · 7 comments
Closed

Find/Replace dialog UI arrangement issues for Mac Version #535

ErickWei opened this issue Apr 1, 2024 · 7 comments
Labels
macos Related specifically to macOS

Comments

@ErickWei
Copy link
Contributor

ErickWei commented Apr 1, 2024

Wish that the dialog box could be updated to be as perfectly arranged as the one in Windows

The main problem is that the widths of the textboxes/combobox are not consistent and they are not left-aligned

MAC OS:
image
image

Windows:
image

@dail8859 dail8859 added the macos Related specifically to macOS label Apr 1, 2024
@dail8859
Copy link
Owner

dail8859 commented Apr 1, 2024

I don't have a Mac to develop/test on so hopefully somebody can submit a PR. My guess is something with the layouts just need tweaked.

@ErickWei
Copy link
Contributor Author

ErickWei commented Apr 2, 2024

Debug via QT on macos,but get an error,Do you have any suggestions on how to solve this issue?

image

@dail8859
Copy link
Owner

dail8859 commented Apr 2, 2024

I'm assuming you also checked out the submodules?

git clone --recurse-submodules https://github.com/dail8859/NotepadNext.git

I know it is possible to build with mac but beyond that I'm not sure.

@ErickWei
Copy link
Contributor Author

ErickWei commented Apr 3, 2024

Just update 4 property of formLayout.

  • layoutLableAlignment-Horizontal:AlignLeft
  • layoutFormAlignment-Horizontal:AlignJustify
  • layoutSizeConstraint:SetNoConstraint
  • layoutFieldGrowthPolicy:First change to ExpandingFieldGrow then change back to AllNonFixedFieldsGrow, and AllNonFixedFieldsGrow is the final value.
    The layoutFieldGrowthPolicy must to be modified, or it won't be effective.I guess it is because, without modification, the program will set different default values for different platforms, which causes UI arrangement problems under the Mac platform.

I have tested both on Windows and Mac, and there is no problem.
image

Modified appearance:
image

But there is one thing to note, when I clone the repository to mac and windows, and open the project with qt, the values of the two property below are different:

MAC:

  • layoutLableAlignment-Horizontal:AlignRight
  • layoutFormAlignment-Horizontal:AlignHCenter

WINDOWS:

  • layoutLableAlignment-Horizontal:AlignLeft
  • layoutFormAlignment-Horizontal:AlignLeft

So, if you are modifying in the windows, you must change layoutLableAlignment-Horizontal to other value first, then change it back to AlignLeft

@dail8859
Copy link
Owner

dail8859 commented Apr 3, 2024

Can you create a PR for whatever works on Mac and I can review it on Windows and make sure it still looks ok?

@ErickWei
Copy link
Contributor Author

ErickWei commented Apr 3, 2024

Can you create a PR for whatever works on Mac and I can review it on Windows and make sure it still looks ok?

Okay,wait for me

@dail8859
Copy link
Owner

dail8859 commented Apr 4, 2024

Closed by #538

@dail8859 dail8859 closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Related specifically to macOS
Projects
None yet
Development

No branches or pull requests

2 participants