Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS Links do not include end day for repeating events #1749

Closed
cocarrig opened this issue Feb 2, 2023 · 1 comment
Closed

ICS Links do not include end day for repeating events #1749

cocarrig opened this issue Feb 2, 2023 · 1 comment

Comments

@cocarrig
Copy link
Collaborator

cocarrig commented Feb 2, 2023

Describe the bug
For ICS links that include repeating events, if they are configured to repeat and end on the same date they will not display. This is because we interpret end date at midnight, when it should include the end date.

To Reproduce
Steps to reproduce the behavior:

  1. Create event that repeats, with end date on the same repeating date.
  2. Add calendar via ICS link into DAKboard screen calendar block.
  3. Note that the last repeating event is not displayed

Expected behavior
The end event of the repeating event should be included.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

@cocarrig cocarrig added the bug label Feb 2, 2023
@Dan-Peck Dan-Peck self-assigned this Feb 3, 2023
@Dan-Peck
Copy link
Collaborator

Dan-Peck commented Feb 7, 2023

Merged in @ 4bef454 and added to the queue for upcoming release to the live site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants