-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU auto-detection feature / cfg gate #529
Comments
Some q's
Having a plain override with |
One use case for us (Signal) is code size, though not on Intel platforms. If there's ever autodetection for mobile platforms, we might want to turn it off if it's not enough of a speedup to be worth the extra code. |
I would think that specifying |
I would think mobile platforms are ARM64, in which case the |
Yeah consensus here seems to be that override seems to be the best. There is this discussion re-opened so let's redirect there to simplify things further: |
Oh sorry, I forgot you opened this issue, but thanks for directing the conversation back to #414 |
Yeah I think we got consensus on this issue so your get-together words it well what needs ot happen overall :) I mainly tried to gather use-cases to surface where additional complexity would be required but I don't think we have any. |
This should not block landing #523 and can be done as follow-up
Follow-up from
Cc/ @jrose-signal @koute
The text was updated successfully, but these errors were encountered: