Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building fails for 2.1.0 as a framework target dependency #354

Closed
onevcat opened this issue Jul 10, 2017 · 4 comments
Closed

Building fails for 2.1.0 as a framework target dependency #354

onevcat opened this issue Jul 10, 2017 · 4 comments

Comments

@onevcat
Copy link
Contributor

onevcat commented Jul 10, 2017

Hi, I am using Starscream as a dependency of a framework like this:

The dependency path is something like this:
MyApp --> MyFramework --> Starscream

MyApp contains a Cartfile depends to MyFramework, and MyFramework contains a Cartfile for Starscream.

Starscream 2.1.0 fails the build of MyFramework when I running carthage update under MyApp folder. It says:

import Starscream // <- missing required module 'zlib'

So it seems that the Zlib module is not visible now when Starscream used as a framework dependency. Maybe it would be better to add zlib as a carthage dependency instead of just defining the module file?

@eliburke
Copy link

I've run into this problem as well. Is there a fix that doesn't involve downgrading to 2.0.x?

@daltoniam
Copy link
Owner

Ah yeah I forgot about Carthage support needing the new dependencies for compression. I personally don't use Carthage, what would need to be done besides adding a Cartfile? I'm also open to PRs 😄.

@daltoniam
Copy link
Owner

I checked in a Cartfile with the latest 3.0.0 release. I don't know if it works, but 🤞.

@daltoniam
Copy link
Owner

I'm going to close this one out based on what has been reported in #389 and the release of 3.0.1. If that doesn't fix it, please reopen the the issue (and PR welcomed too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants