-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using Starscream via Carthage, projects must also include zlib folder #445
Comments
I don't think you should have to do that if I understand how Carthage works properly. I'll admit my knowledge of Carthage is limited, but I thought the Cartfile and such would handle the dependencies? |
@daltoniam Carthage will “only” resolve and download (and build if there’s a framework target) dependencies. Carthage won’t link the dependencies or add them to any Xcode project automatically. So the modules downloaded by Carthage are actually redundant. Since Starscream isn’t using them for its framework target from what I can tell. I’d recommend removing the The same seems to apply to the SPM setup. Since Starscream is using the modulemap in the bundled As it is right now the Cartfile results in a perpetually dirty repository for Carthage users. As Carthage creates To be honest I think bundling the module map as a single file is the best course of action. Even though it sometimes messes up LLDB (¯\_(ツ)_/¯). |
I made a small example repo showcasing that the Carthage dependencies aren’t needed. As well as how Carthage works and how to integrate Starscream via Carthage. The The The I hope that helps clarifying the situation 🙂 |
I think #461 should address this issue. If you could try it out of master and see if works, that would great! |
@acmacalister Doesn't look like it worked for me 😕 |
@acmacalister @codeOfRobin I just deleted the |
I detailed what worked for my project here : After every carthage update we delete the Also we added |
@Bersaelor Thanks, the hack made my code run again, after blocked by this bug for several months. One question though, what purpose does the last step serve, can it be skipped? I run the code under Xcode 9.3 without the last step, it seems to be fine so far. Thanks again. |
Please check with 3.0.6 version. |
When including Starscream with Carthage, project can compile properly, as long as Starscream/zlib resides in Carthage/Checkouts. This should not be the case. So projects that includes Starscream should copy the zlib folder to the project dir, and add it to "Swift compiler - Search Path" in Build Settings.
I think the readme should reflect that?
The text was updated successfully, but these errors were encountered: