-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to create miniseed record with encoded data samples #13
Comments
If I understand you correctly, you'd like to have facilities which allow packing miniSEED records from encoded data samples. Is this correct? EDIT: How would handle the number of samples attribute of the record? Of course, we could pass the number of samples as an additional parameter to the pack function, however, this would be sensible only when packing into a miniSEED |
Hi @damb , I didn't understand why it's only possible/sensible in the case of miniSEED Assume we have the encoded data and num. of smaples,
Moreover, I am thinking it would be make more sense if we have this functionality in libmseed and mseed crate can provide a wrapper around that function. What do you think? |
Sorry for not being clear enough. Packing encoded data and providing the number of samples is only sensible into a miniSEED |
Good point, my suggestion is that this feature creates only a single record (size of rec len = header + encode data < MAX_REC_LEN) and if the encoded data doesn't fit in a single record supported by v2 then send a error message back to caller and let the caller handles that case. |
Does your suggestion work for all As you already suggested, I'd rather prefer an implementation of libmseed. Let's ping @chad-earthscope and ask him what he thinks about this idea. |
Closed due to inactivity. Please, feel free to reopen if required. |
The use case appears quite esoteric. Can a real-world use case be described? Not only would the library (libmseed or this crate) need to blindly trust the encoded payload and number of samples, the end result would likely end up with unfilled v2 records with a lot of padding. It is for these reasons that libmseed includes a msr3_repack_mseed3(), but no v2 equivalent. |
New feature request:
Currently, the mseed crate only support to create miniseed records with raw data samples (i.e, not encoded). It would be good to create a function which can take encoded data samples as input and create a miniseed record.
The text was updated successfully, but these errors were encountered: