Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Debug() vs DebugFormat() vs DebugException() #226

Closed
cd21h opened this issue Feb 27, 2019 · 2 comments
Closed

Debug() vs DebugFormat() vs DebugException() #226

cd21h opened this issue Feb 27, 2019 · 2 comments

Comments

@cd21h
Copy link
Contributor

cd21h commented Feb 27, 2019

For every logging level (e.g. Debug) there are methods with following signatures:

Debug(message)
Debug(func)
Debug(message, formatArgs)
Debug(exception, message, formatArgs..)
DebugException(message, exception)
DebugException(message, exception, formatArgs)
DebugFormat(message, formatArgs)

DebugException and DebugFormat seems to be redundant since the same can be achieved using Debug(..) method calls.

Do we really need them?

@cd21h
Copy link
Contributor Author

cd21h commented Jun 24, 2019

these are duplicates:

  • Debug(message, formatArgs) and DebugFormat(message, formatArgs)
  • Debug(exception, message, formatArgs..) and DebugException(message, exception, formatArgs)

@damianh
Copy link
Owner

damianh commented Dec 4, 2019

They appear to be duplicates. However removing them will be a breaking change and a new major version. As I'm deprecating this library (see #270) so I won't be making fixes here.

@damianh damianh closed this as completed Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants