Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Chrome seems to be broken #13

Open
binarious opened this issue Aug 5, 2018 · 9 comments · May be fixed by #17
Open

Chrome seems to be broken #13

binarious opened this issue Aug 5, 2018 · 9 comments · May be fixed by #17

Comments

@binarious
Copy link

I have the extension installed in Firefox and Chrome with the same configurations. It does work in Firefox but doesn't in Chrome. The developer console shows constant redirects (302) to the target Nextcloud instance.

@damko
Copy link
Owner

damko commented Aug 5, 2018

yes, sorry about that. The bug is confirmed since a while but I had no time to look into it and won't have for a while.
I accept PRs, just saying

@binarious
Copy link
Author

Alright. Going to look into it.

@binarious
Copy link
Author

binarious commented Aug 5, 2018

@damko Do you have a short instruction on how to get this running locally in chrome? Just adding the src folder as an extension leads to:

Unrecognized manifest key 'applications'.

Update: Nevermind. It still works. Seems to be a warning.

@damko
Copy link
Owner

damko commented Aug 5, 2018

you need to go in developer mode https://developer.chrome.com/extensions/getstarted

@binarious
Copy link
Author

binarious commented Aug 5, 2018

Debugged for some time. Copied the exact same request chrome sends and put that into a REST api client (Insomia). I don't get a 302 there. Also used apache_request_headers in the index.php on my nextcloud instance to output the headers - no difference either.

It works with Chromium and Chrome Canary (70).

People from the Passman webextension have similar issues:
nextcloud/passman-webextension#258

Will try some other things when I find more time.

@damko
Copy link
Owner

damko commented Aug 5, 2018

In fact, if it works in FF it should also work in Chrome. It's a weird behavior. Anyway, thanks for the effort

@marcelklehr
Copy link

@damko I've had the same issue in floccus, here's the fix: nextcloud/passman-webextension#270

@binarious
Copy link
Author

Thanks @marcelklehr. Created a PR based on this.

@damko
Copy link
Owner

damko commented Oct 1, 2018

thanks guys, very appreciated. I'm awfully swamped therefore I didn't yet have the chance to look into it. I'll do asap

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants