Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for large contact list #2207

Closed
3 tasks
Tracked by #2194
jb55 opened this issue May 6, 2024 · 4 comments
Closed
3 tasks
Tracked by #2194

Add test case for large contact list #2207

jb55 opened this issue May 6, 2024 · 4 comments

Comments

@jb55
Copy link
Collaborator

jb55 commented May 6, 2024

In order to determine what is happening with

We need to take elsat's account and add it as a testcase.

Steps to test:

  • Send subscriptions to relays on relay list
  • See how long it takes to send request and receive responses
  • Do we get responses at all? If not why not? What is the response message?
@danieldaquino
Copy link
Contributor

Do we get responses at all? If not why not? What is the response message?

From investigating #2194, I found that we get responses to our subscription requests. This is the response message I have seen:

["NOTICE","ERROR: bad req: total filter items too large"]

@danieldaquino
Copy link
Contributor

@jb55 The hard part of this is that we would depend on a relay connection to perform the test.

What do you have in mind for testing that relay connection? Perhaps we can try setting up some form of test strfry relay?

It'd be nice if we can spawn a test relay during the test, but probably not straightforward. Another option would be to setup a strfry test relay instance that is always available for testing, an instance where we can somehow maintain a consistent/controllable test environment (e.g. always revert back to a certain DB state, to avoid having constantly changing feeds)

@alltheseas
Copy link
Collaborator

See related discussion nostr-protocol/nips#1179

In there it was mentioned @Semisol had a large database useful for testing

@jb55
Copy link
Collaborator Author

jb55 commented May 14, 2024

Should be fixed

@jb55 jb55 closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants