Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile picture texture atlas #602

Closed
jb55 opened this issue Dec 19, 2024 · 2 comments
Closed

Profile picture texture atlas #602

jb55 opened this issue Dec 19, 2024 · 2 comments

Comments

@jb55
Copy link
Contributor

jb55 commented Dec 19, 2024

After doing some tests with ./preview ProfilePic it's pretty clear that loading textures individually is simply too slow to render them all at once, which we may want to do for notedeck_viz

We can create a giant texture with all of the profile pictures and use that as a texture atlas. For everything else we can load it dynamically as we need it.

I found some example code that uses the same underlying texture handles in different TextureIds:

On closing of the application we could write this atlas to disk, and then load it again on next startup?

@jb55
Copy link
Contributor Author

jb55 commented Dec 19, 2024

This could be a feature of ImageCache

@jb55 jb55 added the technical label Dec 19, 2024
@jb55
Copy link
Contributor Author

jb55 commented Jan 6, 2025

The slowness was a bug with choosing the wrong preview cache dir

@jb55 jb55 closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant