Skip to content
This repository has been archived by the owner on May 7, 2019. It is now read-only.

Dynamically changing the number of tabs #15

Open
divyenduz opened this issue Dec 30, 2015 · 0 comments
Open

Dynamically changing the number of tabs #15

divyenduz opened this issue Dec 30, 2015 · 0 comments

Comments

@divyenduz
Copy link

Hey,

I realized that when the state changes such that the number of children is dynamic (based on state). The component uses this.props.children.length to measure pageWidthPerCent value. So, it uses the initial number of children and the page width math goes wrong.

Have you considered putting children length in state and update it at right times to calculate the page width.

If you are interested, I can pitch in with a PR.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants