Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working with video files #918

Open
Saksham20 opened this issue Feb 21, 2022 · 1 comment
Open

working with video files #918

Saksham20 opened this issue Feb 21, 2022 · 1 comment

Comments

@Saksham20
Copy link
Contributor

Saksham20 commented Feb 21, 2022

Related to the recent merge: #841 There are two things that I would like to discuss:

  1. Currently to validate and upload video files we need to specify the option allow-any-path. Since we now explicitly organize video files with dandi organise I dont think this options is a good idea as the user may be able to upload other unwanted files along with videos. Additionally, for this option to work the DANDI_DEVEL env variable needs to exist so any user would need to do: DANDI_DEVEL=1 dandi validate --allow-any-path. This is rather un-user-friendly for common users. (edit by @yarikoptic - dedicated Add VIDEO_FILE_EXTENSIONS into the "default" set #920 )
  2. Need to validate video files:
  • Currently we support the organization of ".mp4", ".avi", ".wmv", ".mov", ".flv" formats. Validation could enforce these extensions. While this list of file containers are only a start, we will build a better list once things get rolling and we encounter different video formats used in animal experiments.
  • It is theoretically possible for acquisition systems to output corrupted videos: have dropped frames, no frames. Ideally its the users responsibility to correct this so may not be something for DANDI to worry about. These errors could be checked by opening the file using opencv within a try/except block. I am not sure if this happens often enough to make it a necessary check everytime.
@yarikoptic
Copy link
Member

re validation

  • ATM I think we just ignore files with unknown extensions, we might need to adjust what we do. Filed validate should stop skipping/ignoring files #921 so we elaborate
  • we would need to familiarize with opencv on what it depends on for opening video files. If that is some external libraries, then situation might vary widely across systems/installations thus making such validation "fragile".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants