Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Do not add or remove file ending newline character #199

Closed
SpicyLemon opened this issue Nov 2, 2023 · 2 comments
Closed

Bug: Do not add or remove file ending newline character #199

SpicyLemon opened this issue Nov 2, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@SpicyLemon
Copy link

As a dangoslen/dependabot-changelog-helper user, I would like the lack or presence of a file-ending newline character to be maintained so that the PR diffs are smaller and it's not always getting changed back and forth as other users update the changelog.

Background: In our org, we tell everyone to set up their IDEs to include a newline char at the end of files. This changelog helper keeps trying to delete it the newline at the end of the changelog, though. So the last line of the changelog shows up in the diff a lot, and it'd be nice if that could be kept clean.

@dangoslen dangoslen added the bug Something isn't working label Nov 2, 2023
@dangoslen
Copy link
Owner

Thanks for raising the issue. I will take a look as soon as I can, which is realistically this weekend.

Always happy to review a PR if you want to make an update yourself!

@dangoslen dangoslen changed the title Feature: Do not add or remove file ending newline character Bug: Do not add or remove file ending newline character Nov 7, 2023
@dangoslen dangoslen modified the milestones: v4.0, v3.6.0 Nov 7, 2023
@github-actions github-actions bot mentioned this issue Nov 11, 2023
@dangoslen
Copy link
Owner

@SpicyLemon - this should be fixed in the upcoming 3.6.0 release. The original PR did not fix it, but I have corrected it while cutting the 3.6.0 release in PR #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants