Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Renovate #228

Open
SubJunk opened this issue Jan 7, 2024 · 3 comments
Open

Feature request: Renovate #228

SubJunk opened this issue Jan 7, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SubJunk
Copy link

SubJunk commented Jan 7, 2024

Hi, thank you so much for this action, it is very useful.
Is there any chance you could add support for Mend Renovate? https://github.com/marketplace/renovate

Their support for monorepos makes them invaluable for me, along with some configuration options Dependabot doesn't offer, for example here SubJunk/TimelineTools#1194 it updated 11 packages in one PR, so I would love to use it with this instead of having to stick with Dependabot

@dangoslen
Copy link
Owner

Great idea. Never heard of Renovate, but it makes sense to me.

I took at a look at that PR - do you have any other examples?

From a high-level, I think we would need to essentially create

  • a new RenovateEntryExtractor that parses renovate PRs for the versions
  • Ability to switch between DependabotEntryExtractor and Renovate - likely based on the author - via a factory
  • put a new EntryExtractor interface in place that can be used across both

Once Entries are extracted, the rest of the Changelog updates should flow seamlessly.

I'll see if I can get started on this later this month (have some important work in the day-job in the coming weeks). But I'm always open to contributions and I think this should be pretty easy to get started.

What I might do is add some of the refactors to add the factory/interface in a PR. Would you be up for trying to add the Renovate support if I get that scaffolding setup?

This idea does introduce a new problem though: how do I rename my action now? 🙃

@dangoslen
Copy link
Owner

I also think we could create another input to select the entry format vs. trying to do any auto-selection. Auto-selection I think would be pretty cool... but maybe having an "escape hatch" input could help.

@SubJunk
Copy link
Author

SubJunk commented Jan 7, 2024

@dangoslen thanks for the thoughtful responses. An example from the repository I use this Action in is here UniversalMediaServer/UniversalMediaServer#3754
Yes I can try to continue on from your scaffolding, I get busy in my day job too but I will try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants