Sometimes adds a </li> #278
Comments
|
Interesting. Very odd bug. Will take a look! |
|
After much head scratching, I've realized that there is a problem in the regex that extracts the version bumps from the description. In the PR, the description has a commit that matches the regex:
It sounds like I need to restrict the regex here for lines that start with the initial search word. The current regex can match the line at any place in the line, which I think lead to this bug Will see if I can tackle this soon! TY for reporting and bearing with me |
|
Cool, it seems like a rare problem so I'm not worried, thanks |
|
I got this changelog entry: Not exactly what I had imagined 😆 Dependabot actually only made these changes:
|
|
What about changing
to
That would require the update/bump line to come before a newline and the |
|
Thanks for chiming in @CramBL I actually do have a fix for this on a local branch that I just never got around to polishing and pushing. I'll open that shortly |
Merged
Merged
|
Should be fixed in 3.11.0 |
|
I still get the same faulty changelog entry Log shows I'm on newest version: Changelog entry: ### Dependencies
- Bump `crate-ci/typos` from 1.27.0 to 1.28.4 ([#39](https://github.com/luftkode/settings-manager/pull/39))
- Bump `docker/login-action` from 3d58c274f17dffee475a5520cbe67f0a882c4dbb to 7ca345011ac4304463197fac0e56eab1bc7e6af0 ([#39](https://github.com/luftkode/settings-manager/pull/39))
- Bump `<code>@docker/actions-toolkit</code>` from 0.40.0 to 0.42.0</li> ([#39](https://github.com/luftkode/settings-manager/pull/39))
- Bump `<code>@actions/core</code>` from 1.10.1 to 1.11.1</li> ([#39](https://github.com/luftkode/settings-manager/pull/39))The whole dependabot message that lead that entryBumps the github_actions group with 2 updates in the / directory: [crate-ci/typos](https://github.com/crate-ci/typos) and [docker/login-action](https://github.com/docker/login-action).Updates Release notesSourced from crate-ci/typos's releases.
... (truncated) ChangelogSourced from crate-ci/typos's changelog.
... (truncated) Commits
Updates Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting Dependabot commands and optionsYou can trigger Dependabot actions by commenting on this PR:
|
|
Will take a deeper look! |
|
Maybe you can reopen it so I/we(?) can track it? |
|
For context here's the workflow where I observe the issue: name: Bump patch version on Dependabot PRs
on:
pull_request:
types: [opened, reopened]
branches: [ main, master ]
jobs:
update-release-file:
if: github.actor == 'dependabot[bot]'
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
steps:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v2
- name: Init Artisan Tools
run: just init-at
- name: Bump patch version
run: |
just at version bump patch
echo "NEW_VERSION=$(cat RELEASE)" >> $GITHUB_ENV
- name: Create new CHANGELOG section
run: |
CURRENT_DATE=$(date +"%Y-%m-%d")
NEW_SECTION="## [${{ env.NEW_VERSION }}] - ${CURRENT_DATE}\n"
sed -i '0,/^## \[/s//'"${NEW_SECTION}"'\n&/' CHANGELOG.md
- uses: dangoslen/dependabot-changelog-helper@v3
with:
activationLabels: 'dependencies'
version: ${{ env.NEW_VERSION }}
changelogPath: './CHANGELOG.md'
- uses: stefanzweifel/git-auto-commit-action@v5
with:
commit_message: "Updated Changelog and bumped to ${{ env.NEW_VERSION }}" |
|
@CramBL I believe I've solved this now. Would you mind confirming by updating the action in your workflow to use |
|
I made the change you suggested and made dependabot recreate the PR but now it fails to run. I cannot tell what's causing dependabot to error. I made only that change ( |
|
No sorry, reverting the change did not fix anything. Dependabot has an issue right now. |
|
Sorry for being MIA yesterday. I did update this repo on Let me know when you have a chance to confirm and I can release quickly after (just a few merges to upstream branches to add the tags) |
|
On the private repo dependabot still doesn't run but I used it on a public one: https://github.com/luftkode/plotinator3000 And there's another issue with the dependency entry. The changelog helper workflow is here: https://github.com/luftkode/plotinator3000/blob/master/.github/workflows/dependabot_changelog.yml And the changelog entry looks like this: ### Dependencies
- Bump `serde` from 1.0.215 to 1.0.216 ([#143](https://github.com/luftkode/plotinator3000/pull/143))
- Bump `chrono` from 0.4.38 to 0.4.39 ([#143](https://github.com/luftkode/plotinator3000/pull/143))
- Bump `semver` from 1.0.23 to 1.0.24 ([#143](https://github.com/luftkode/plotinator3000/pull/143))
- Bump `env_logger` from 0.11.5 to 0.11.6 ([#143](https://github.com/luftkode/plotinator3000/pull/143))
- Bump `zip` from 2.2.1 to 2.2.2 ([#143](https://github.com/luftkode/plotinator3000/pull/143))
- Bump `wasm-bindgen-futures` from 0.4.47 to 0.4.49 ([#143](https://github.com/luftkode/plotinator3000/pull/143))
- Bump `web-sys` from 0.3.74 to 0.3.76 ([#143](https://github.com/luftkode/plotinator3000/pull/143))
- Bump `thiserror` from 2.0.4 to 2.0.9 ([#143](https://github.com/luftkode/plotinator3000/pull/143))So there's an extra line ending after the first entry. I observed the same thing in the other repo. There should also be a blank line between the section header and the first entry. See markdown-guide.org about headings, google's markdown style guide etc. |
|
I see the same issue here on a personal project of mine: https://github.com/CramBL/fidelityfetch/pull/35/files ## [unreleased]
### Dependencies
- Bump `clap_complete` from 4.5.38 to 4.5.40 ([#35](https://github.com/CramBL/fidelityfetch/pull/35))
- Bump `mdns-sd` from 0.13.0 to 0.13.1 ([#35](https://github.com/CramBL/fidelityfetch/pull/35))
- Bump `thiserror` from 2.0.7 to 2.0.9 ([#35](https://github.com/CramBL/fidelityfetch/pull/35))
## [0.4.1]
### Changed
...It should also add a newline after the last entry |
|
Thanks for reporting these bugs! I've fixed this newline after the first entry vs. the last (effectively the same bug in reality). I reported that in a new issue for tracking purposes, but I should have a PR shortly. Adding the newline after the heading is a good idea, but I wouldn't call it a bug. The style guide you reference is great but not strictly necessary. I'll address that in a |
|
The I'll try to cut the tag if you have time to verify, but I will be slow to respond the rest of this week with Christmas plans. Thanks for your patience on this and for reporting the issues! |
Merged
|
Hi @dangoslen just want to let you that I made an action for creating changelog entries from dependabot PRs now, to fit my own needs which includes committing and pushing the changes. It doesn't do everything |
|
Thanks for letting me know! Sorry, this action didn't fit your needs, but glad it was able to help you in at least some way. Let me know when it is published, and I'll be sure to link out to whatever your project is an alternative to this project as well. Thanks again for your patience and for opening up the issues. |
|
Hi @dangoslen, just letting you know I published the action at https://github.com/marketplace/actions/dependabot-changelog-writer 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can be seen here UniversalMediaServer/UniversalMediaServer@6caa293
The text was updated successfully, but these errors were encountered: