Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress doesn't work without shim #51

Closed
lukecyca opened this issue Nov 20, 2013 · 3 comments
Closed

progress doesn't work without shim #51

lukecyca opened this issue Nov 20, 2013 · 3 comments

Comments

@lukecyca
Copy link

I only need to support very modern browsers, so I didn't include the shim at first.
It seems that without the shim loaded, the progress/load event handlers never get set up, and so config.progress is never called and there is no way to update progress in my UI.

@danialfarid
Copy link
Owner

Yea it is mentioned in the README guide that you need shim for progress/abort.
It is to get access to Angular XHR private field: angular/angular.js#1934
I can create a separate file for only HTML5 angular shim which would be less code but overall the shim file is very tiny even with non-HTML5 code.

@lukecyca
Copy link
Author

ok thanks. I'll just include the shim then. I should have RTFM. :)

@danialfarid
Copy link
Owner

OK I created the html5-shim.js which is very tiny 500 bytes.
You can use that instead of the normal shim.js.
It is in version 1.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants