Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with Erlang/OTP 24 #155

Closed
marcandre opened this issue May 28, 2021 · 2 comments
Closed

Not compatible with Erlang/OTP 24 #155

marcandre opened this issue May 28, 2021 · 2 comments

Comments

@marcandre
Copy link

Erlang/OTP 24 dropped :crypto.hmac.

=> ex_twilio
Compiling 74 files (.ex)
warning: :crypto.hmac/3 is undefined or private, use crypto:mac/4 instead
  lib/ex_twilio/request_validator.ex:35: ExTwilio.RequestValidator.compute_hmac/2

One must use :crypto.mac/4 which is OTP 22+

FYI, the package plug_crypto was updated to tackle the same thing in elixir-plug/plug_crypto@cf901bd and elixir-plug/plug_crypto@8c1f927

Let me know if I need to write a PR for this.
@seantanly
Copy link
Contributor

seantanly commented May 29, 2021 •
edited
Loading

This is addressed in PR #154
Will be nice if that's merged and we get a new release.

@marcandre
Copy link
Author

Oh, perfect. Closing in favor of #147 / #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcandre @seantanly