Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for next/dynamic import #426

Closed
wants to merge 1 commit into from
Closed

fix support for next/dynamic import #426

wants to merge 1 commit into from

Conversation

krish-dev
Copy link

#236
Just added one condition into copyLambdaHandlerDependencies method to coping chunks into the valid directory. Ref

#357
also added service-worker support.

@danielcondemarin
Copy link
Contributor

danielcondemarin commented Jun 3, 2020

@krish-dev Thanks for the PR and being on top of this issue! However I've already approved and merged #425. Sorry that this wasn't communicated properly and you both ended up working on the same thing.

With regards to the service-worker fix, I'd like to have a solution that works for any filename rather than hardcoding service-worker.
My preferred solution would be to allow users to add a custom cache behaviour. Most of the work is already done, however I suspect there is a bit more to do to support your use case. Let me know if you want to take a stab at this and I'm happy to assist where I can.

@krish-dev
Copy link
Author

@krish-dev Thanks for the PR and being on top of this issue! However I've already approved and merged #425. Sorry that this wasn't communicated properly and you both ended up working on the same thing.

No worries, Your current release (serverless-next.js@1.12.0-alpha.8) works perfectly.

With regards to the service-worker fix, I'd like to have a solution that works for any filename rather than hardcoding service-worker.
My preferred solution would be to allow users to add a custom cache behaviour. Most of the work is already done, however I suspect there is a bit more to do to support your use case. Let me know if you want to take a stab at this and I'm happy to assist where I can.

I'm agreed with you and I'm also against hardcoding, It was just a quick fix by considering service-worker is a special case. Yes, I would like to take a stab at this, I will appreciate if you just give me a hint that what you suspect. If you wish you can create a separate communication thread by opening an RFC or you continue with the issue #357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants