Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_box returns null when passed an empty string #5

Open
eliotstock opened this issue Oct 22, 2011 · 1 comment
Open

compute_box returns null when passed an empty string #5

eliotstock opened this issue Oct 22, 2011 · 1 comment

Comments

@eliotstock
Copy link

Firstly, thanks for the port. It's exactly what I need.

The call stack for my use case is something like this:

best_bbox_search_cells
min_resolution remains as 0 (not sure if this is expected or not)
cur_ne and cur_sw are initially empty strings
interpolation_count is passed empty strings
compute_box is passed an empty string

In the Java version, computeBox() would return the following when passed an empty string:

BoundingBox bbox = new BoundingBox(90.0f, 180.0f, -90.0f, -180.0f);

But in your JS version, the following code returns null:

if (!cell_) {
return null;
}

That later results in the following error in interpolation_count:

caught TypeError: Cannot call method 'getNorth' of null

at this line:

var cell_lat_span = bbox_sw.getNorth() - bbox_sw.getSouth();

Haven't provided a patch since I'm not sure of the best fix.

Thanks,

Eliot.

@danieldkim
Copy link
Owner

Hi Eliot,

Glad you found this useful and thanks for the report. Can your provide a code sample or sample data? Knowing what input to best_bbox_search_cells() generates this issue would be helpful in figuring out the most appropriate way to handle it.

Thanks,
-dk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants