Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] make Marker a protocol #1278

Closed
farfromrefug opened this issue Jul 30, 2016 · 5 comments
Closed

[FR] make Marker a protocol #1278

farfromrefug opened this issue Jul 30, 2016 · 5 comments

Comments

@farfromrefug
Copy link

I am using Charts in an Objective C library project. The issue is that Marker is a swift class so i can't subclass it in Objective-C. I also can't make a swift class in my Objective-C project because it is a static library.
The solution for Marker to work in any kind of project would to make ChartViewBase's marker an "id" of Protocol "Marker". Then you could simply Make BallonMarker inherite from "BaseMarker" which would implements the "Marker" protocol.

If you are ok with the idea i will make a simple PR.

Thanks

@liuxuan30
Copy link
Member

liuxuan30 commented Aug 1, 2016

Why can't you use framework or source code, but only static library?
I'm open to protocol, but not sure if worthy only to solve the static library stuff

@farfromrefug
Copy link
Author

I am actually creating a module for an cross-platform framework called Titanium Mobile.
For now the module are made of a static library loaded at runtime. So in this case i actually can't use the framework nor source code (you can put swift code in static lib).
So i don't really have a solution as of right now.
Would be the same thing if someone were to make a PhoneGap module.

I am thinking about switching the Titanium modules to framework but it would take time to implement.
That's why i think make Marker a framework would be the best solution for all.

@liuxuan30
Copy link
Member

@danielgindi what you think?

@danielgindi
Copy link
Collaborator

danielgindi commented Aug 4, 2016

Already done on v3 :-) (Not on master yet)

@farfromrefug
Copy link
Author

@danielgindi that s awesome :D will try it as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants