-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] make Marker a protocol #1278
Comments
Why can't you use framework or source code, but only static library? |
I am actually creating a module for an cross-platform framework called Titanium Mobile. I am thinking about switching the Titanium modules to framework but it would take time to implement. |
@danielgindi what you think? |
Already done on v3 :-) (Not on |
@danielgindi that s awesome :D will try it as soon as possible! |
I am using Charts in an Objective C library project. The issue is that Marker is a swift class so i can't subclass it in Objective-C. I also can't make a swift class in my Objective-C project because it is a static library.
The solution for Marker to work in any kind of project would to make ChartViewBase's marker an "id" of Protocol "Marker". Then you could simply Make BallonMarker inherite from "BaseMarker" which would implements the "Marker" protocol.
If you are ok with the idea i will make a simple PR.
Thanks
The text was updated successfully, but these errors were encountered: