Crash in Charts v2.2.5-Swift3.0

[madhikarma]

Hi there

I found a crash at runtime using the Chart2.2.5-Swift3.0 branch

In certain circumstances the CGPoint created in the lowestVisibleXIndex method returns NaN (see screenshot below)

We were hoping to use with this version of the Charts API whilst we wait for the Charts 3 / Swift 3.0 release (and with that the new APIs for the library )

Can you advise about fixing the problem or whether its safe to use the branch or if we need to Charts 3?

Thank you for your time and for this library

[madhikarma]

...using Xcode 8.0 GM / iOS 10 SDK and running on the iPhone 5s Simulator

[liuxuan30]

giving the code you post, pt is just the left bottom corner, which should be a valid constant. I suspect something wrong with the transfomer or your setup. When do you get this crash? What's your x values, and data entries at that moment?

Could you debug more? e.g. print out viewPortHandler.contentRect, print out pt value before transfrom, print out the transformer pixelToValueMatrix, print out pt after transform.

if pt is really the valid left bottom corner point coordinates, and after the transform, it is NaN? Then the matrix messed up.

Also, it's better it can be produced by ChartsDemo so we could debug. But for now, you have to debug on your side.

Never seen this reported by others I remember.

[pmairoldi]

since we have no plans to officially support swift 3.0 with chart 2.x we should close all issues related to it and delete the branch to avoid confusion.

[madhikarma]

Makes sense, I thought it was worth trying the branch to keep the same Charts API but gain Swift 3.0 support.

I was able to patch the crash above with a NaN check inside the method but several more crashes occurred in other methods with the data set we were using so we stopped.

The same data set with the v2.3.0 Swift 2.3 branch https://github.com/danielgindi/Charts/tree/v2.3.0 did not crash so we migrated to Swift 2.3 instead until Charts 3.0 Swift 3.0 is finalised.

[pmairoldi]

Glad to hear you got things working. If you want charts 3.0 sooner you can always help closing the remaining issues 😉