Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to move data labels outside the chart. #1687

Closed
hb2708 opened this issue Oct 20, 2016 · 7 comments
Closed

How to move data labels outside the chart. #1687

hb2708 opened this issue Oct 20, 2016 · 7 comments

Comments

@hb2708
Copy link

hb2708 commented Oct 20, 2016

@danielgindi
I want the data labels to be outside the chart like below.

Please Guide
screen shot 2016-10-20 at 2 53 14 pm

@hb2708
Copy link
Author

hb2708 commented Oct 21, 2016

@danielgindi @petester42 I did succeeded in the above goal by doing some tweaks in library but i am still not able to find the correct way as changing the library is not a ideal way please guide

@liuxuan30
Copy link
Member

liuxuan30 commented Oct 21, 2016

just override them with your sub classes or change the library code. Sometimes customizations are needed if it does met your requirement.

@hb2708
Copy link
Author

hb2708 commented Oct 21, 2016

can't it be like different public setting in library without setting it by changing the code in library as if i update it to newer version i again need to do the change in new code of library

@liuxuan30
Copy link
Member

Yes, that's true. because it's your customizations; however you could make a pull request for features you think it's helpful and get merged and you won't need to change again;

if you can't make it public, then what you should do is to subclass and override in your sub class. That's why we use OOP

@hb2708
Copy link
Author

hb2708 commented Oct 25, 2016

Is it ok if i create a pull request to master branch

@hb2708
Copy link
Author

hb2708 commented Oct 25, 2016

Hello i have created the pull request by updating my solution #1712
let me know if any improvements required

@liuxuan30
Copy link
Member

Thanks! Just wait and keep tuned. The review process will take some time for code styles or other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants