Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis does not use github token for pull request build #1734

Closed
pmairoldi opened this issue Oct 27, 2016 · 3 comments
Closed

Travis does not use github token for pull request build #1734

pmairoldi opened this issue Oct 27, 2016 · 3 comments
Assignees

Comments

@pmairoldi
Copy link
Collaborator

Because travis does not load the github token for pull requests, the build sometimes fails when we can't download the realm binaries.

@pmairoldi pmairoldi self-assigned this Oct 27, 2016
@danielgindi
Copy link
Collaborator

Hmm I hate it when it's "sometimes"... I'm guessing that free Travis have a specific capacity

@pmairoldi
Copy link
Collaborator Author

It's not ambiguous though. Since the github token is not loaded eventually the "max number of downloads" for unauthorized requests will be hit. When that happens the build fails since it has to actually build realm which takes longer than 10 minutes (the limit of Travis builds)

@pmairoldi
Copy link
Collaborator Author

Seems like Travis now builds for more than 10 minutes so even Carthage fails to download dependencies we should still be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants