Memory Leak in Horizontal Bar Chart

[chuynadamas]

Leak in horizontal bar chart

I just find a leak on the horizontal bar chart, you can reproduce it if you open your demo project hit the horizontal bar chart example multiple times and then check the memory graph, i'll add some screen about how it looks.

Retain cycle

Objects created

I checked on your history issues, it seems that you guys have one related an apple bug, is this the same problem #2425 I'm using your latest version.

Thanks in advance :)

[liuxuan30]

It's different in #2425. This is about the CALayer and the view itself.
How to read this graph, especially malloc?

I tried instruments, it indeed looks like CALayer has leak (as well as the chart view itself):

Also, I added dealloc in horizontal bar chart view controller, when popping back, dealloc is called, but the chart view seems hold by something and cannot released:

2017-08-23 10:37:06.365 ChartsDemo[60964:24310892] hori. dealloc!
(lldb) po self
<HorizontalBarChartViewController: 0x7fde16f36e50>

(lldb) po self.chartView
<Charts.HorizontalBarChartView: 0x7fb064e033e0; frame = (0 47; 375 437); autoresize = RM+BM; gestureRecognizers = <NSArray: 0x60800005dbe0>; layer = <CALayer: 0x6000002241a0>>

After dealloc is finished, in runtime:

(lldb) po 0x7fde16f36e50  // view controller
140591844519504

(lldb) po [0x7fb064e033e0 retainCount]  // self.chartView
0x0000000000000001

(lldb) po [0x6000002241a0 retainCount]  // self.chartView.layer
0x0000000000000001

I am not sure what causes the leak right now, as we don't touch CALayer. Can someone help?

If not, I could personally file a DTS request to Apple to help when I got time on this.

[liuxuan30]

I checked CALayer's stack trace, there is one unpaird group which looks like to your memory graph, but I don't understand right now.

[liuxuan30]

@chuynadamas can you try on a real device with older iOS version? I don't have old simulator right now nor device. I can try find a iOS 9 device maybe tomorrow.

[chuynadamas]

@liuxuan30 I did the test with a real device running 10.3.3 I don't have devices with older versions, maybe tomorrow i could find one too or download an old simulator.

[liuxuan30]

I asked a UIKit dev on twitter but no response at all.. Seems need a DTS or bug report. I am not sure if it's on us or Apple's bug. Looks like it's apple as we don't manage CALayer on our side

[liuxuan30]

filed a radar: 34298100

[DamirDjozicCoing]

I posted a comment on this memory leak issue on other thread. Please check that and let me know if that solves the issue.

#2772

Hope that helps!

[liuxuan30]

this issue seems more like for #3078 rather than #2772

[liuxuan30]

@chuynadamas reopen(if you can) if this does not solve yours.