Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty configuration over full configuration #308

Closed
pmairoldi opened this issue Aug 19, 2015 · 6 comments
Closed

Empty configuration over full configuration #308

pmairoldi opened this issue Aug 19, 2015 · 6 comments

Comments

@pmairoldi
Copy link
Collaborator

So I've finally integrated some charts into my project using this but I am finding that out of the box charts are configured too much. There is a chart description, a legend, and a bunch of other stuff that the simple use case would not need. I think it might be a good idea to rethink of what "needs" to be included in a base chart.

This would reduce the need for turning everything off that I don't need and just turn on things I want. I think that everything off be default would be way better and reduce the amount of code someone would have to write to get something they want on screen.

What's everyone's thoughts on this?

@danielgindi
Copy link
Collaborator

@PhilJay

@liuxuan30
Copy link
Member

Turning legends, desciption off by default is fine, but sometimes, when I see additional stuff I don't expected, I would take a look and learn something new. It's always good to find out some small features in the chart :)

@alinoz77
Copy link

Maybe make sense to have a turn all off/on method.

@pmairoldi
Copy link
Collaborator Author

@liuxuan30 if you are learning new things about the library by mistake wouldn't that mean that the documentation is lacking?

@liuxuan30
Copy link
Member

@petester42 I read the document from android WIKI, but I now get used to read code directly... Thanks to Swift, it's easy to read. enhancing WIKI is also a good choice.

@pmairoldi
Copy link
Collaborator Author

closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants