-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4.1 compilation warnings #3323
Comments
use master instead. Or wait 3.1 released. |
Please re–open. Master has the same issues. These are from building with master:
|
don't use Version 9.3 beta |
Uh I’m giving you a heads up about the issue, obviously I don’t have to use the beta. Sometimes it’s smart to test your codebase (especially if you are in a large company) against Xcode betas so you can see potential sources of work ahead of time. This is me doing you a courtesy by letting you know that your project needs work for the upcoming Swift version. |
Xuan knows the problem but as long as it is a beta version he will not do anything he is waiting for the release version |
@alanzeino Thanks for the heads up. Generally we have a branch around that tracks these changes. I made it on my fork by accident this time, so it doesn't show up on the main Charts repo. We're ready for Swift 4.1. Don't worry ; ) |
oh, I must be drunk, I though swift 4.1 is an old version... |
Bunch of warnings with version 3.0.5 of Charts and latest Swift 4.1 beta in Xcode 9.3 b4. Worth fixing because they're all very quick fixes and because some developers using
-warnings-as-errors
will see these as errors in their codebase.Should also be an opportunity to remove the force unwraps and casts that are unnecessary. Most of these errors can be written using
guard let
orif let foo = foo
instead.The text was updated successfully, but these errors were encountered: