Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout issue with chart legend #3359

Closed
1 task done
floriangbh opened this issue Mar 22, 2018 · 2 comments
Closed
1 task done

Layout issue with chart legend #3359

floriangbh opened this issue Mar 22, 2018 · 2 comments

Comments

@floriangbh
Copy link

What did you do?

Update to v3.1.

What did you expect to happen?

No regression :)

What happened instead?

Before v3.1
before 3 1
After v3.1
after 3 1

Issue happen with chart legend.

Charts Environment

Charts version/Branch/Commit Number: 3.1 with Carthage
Xcode version: 9.2
Swift version: 4.0.3
Platform(s) running Charts: iPhone
macOS version running Xcode: 10.13.3

@geberl
Copy link

geberl commented Apr 5, 2018

Can confirm. Updated from 3.0.5 to 3.1.1 and see something similar.

It seems to be more an issue of the chart being taller now than the legend being positioned too far up. Can't tell from @floriangbh screenshots.

charts_legend_issue

For the meantime I found that adding an extraBottomOffset of CGFloat(32) to the chart leads to the previous result.

I like the new version more by the way. Linebreaks in the legend seem to be improved, before there was overflow/cutting occurring (right screenshot: "Archiv" should be "Archives").

Charts Environment

Charts version/Branch/Commit Number: 3.1 with CocoaPods
XCode version: 9.3
Swift version: 4.1
Plattform(s) running Charts: iPhone, iPad
macOS version running Xcode: 10.13.4

@floriangbh
Copy link
Author

Fixed with setExtraOffsets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants