DrawValuesEnabled variable unreachable (Swift 4.2)

[Jordanwayne]

• [X ] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?

I wanted to implement PieCharts into my app without many of the labels associated. I tried many of the available functions but couldn't find any that would turn off the values (not just the value names) on the pie chart itself. Looking into the library, I found that if I set drawValues on line 335 of Source > Charts > Renderers > PieChartRenderer.swift to false (overriding dataSet.isDrawValuesEnabled) it achieves the solution I was looking for.

I imagine there is probably a function call that was meant to achieve this for the user but it appears in Swift 4.2 it isn't reachable anymore. I'm not sure of this fix but I thought I'd bring it to your attention.

What did you expect to happen?

I thought that by turning off drawEntryLabelsEnabled, it would disable both the label and the value from the pie chart.

What happened instead?

The value label remained and there didn't seem to be a function call that would disable them.

Charts Environment

Charts version/Branch/Commit Number:
Xcode version:
Swift version:
Platform(s) running Charts:
macOS version running Xcode:

Demo Project

[pmairoldi]

drawValuesEnabled would be the property that you would need to change but it does seem that setting that to false still keeps the label. Don't really know if this is a bug though. @liuxuan30 what do you think? Should we add a new option for the label or just use isDrawValuesEnabled for both value and label?

[pmairoldi]

To turn off both value and labels you can do the following:

chartDataSet.drawValuesEnabled = false
chart.drawEntryLabelsEnabled = false

[Jordanwayne]

Ok thanks, I'll try that instead.

[liuxuan30]

I don't think it's a bug. Pie chart value labels have both x and y value label:

                let drawXOutside = drawEntryLabels && xValuePosition == .outsideSlice
                let drawYOutside = drawValues && yValuePosition == .outsideSlice
                let drawXInside = drawEntryLabels && xValuePosition == .insideSlice
                let drawYInside = drawValues && yValuePosition == .insideSlice

drawEntryLabels seems only affect x values.

in the beginning of drawValues loop:

            if !drawValues && !drawEntryLabels && !dataSet.isDrawIconsEnabled
            {
                continue
            }

it's designed to let you can disable x and y entry label respectively. Check out the pie chart demo to toggle x and y values