improve comment to warn users how to use setVisibleRange APIs #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is a good idea but i find your change confusing. You description of your change in the parenthesis makes more sense to me. I would say something more like that. "Chart must have data or these have no effect". |
|
@dxclancy thanks a lot, not a native speaker, so.. thanks |
liuxuan30
force-pushed
the
ImproveComment
branch
from
623ade5
to
1e41a5b
Compare
liuxuan30
force-pushed
the
ImproveComment
branch
from
1e41a5b
to
eadefab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing some users don't know how to use setVisibleRange APIs (can only be called after we have data, otherwise no effect). For now, add the API description for this