Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single test target to make coverage easier #1563

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Conversation

pmairoldi
Copy link
Collaborator

There was a problem with Charts test coverage being overwritten by ChartsRealm since it depends on it. There is really no case where our tests should not be combined.

@codecov-io
Copy link

codecov-io commented Sep 27, 2016

Current coverage is 18.31% (diff: 100%)

Merging #1563 into master will decrease coverage by 0.94%

@@             master      #1563   diff @@
==========================================
  Files           110        122    +12   
  Lines         13043      13718   +675   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2513       2513          
- Misses        10530      11205   +675   
  Partials          0          0          

Powered by Codecov. Last update 3a2da1b...c420794

@pmairoldi pmairoldi merged commit 873c4eb into master Sep 27, 2016
@pmairoldi pmairoldi deleted the single-test-target branch September 27, 2016 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants