Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #1488, #1564
@danielgindi I need you carefully review this and give details about existing implementation about centerAxisLabels feature. My changes may lack of information and cause more issues, though I have tesed it in time line chart, bar chart, combined chart, multiple bar chart, line chart.
n
value, becausefirst
andlast
will be equal after zooming a lotcenterAxisLabelsEnabled
condition, if entry count > 0, we could turn on centerAxisLabel. I need context why it's> 1
.centeringEnabled
, becauseaxis.entries
would be changed butcenteringEnabled
keeps reading old entryCount, which seems a dirty read issueoffset: Double = interval / 2.0
instead ofoffset = (axis.entries[1] - axis.entries[0]) / 2.0
, becauseaxis.entries[1] - axis.entries[0]
always equals to interval, and when there is only one entry, we still need a valid offset instead of 0