Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check against NaN #1733

Merged

Conversation

Selficide
Copy link

There needs to be a check against NaN after ChartUtils::roundToNextSignificant() returns.

There needs to be a check against NaN after
ChartUtils::roundToNextSignificant() returns.
@codecov-io
Copy link

Current coverage is 18.83% (diff: 100%)

Merging #1733 into master will increase coverage by 0.14%

@@             master      #1733   diff @@
==========================================
  Files           123        123          
  Lines         14052      13941   -111   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2626       2626          
+ Misses        11426      11315   -111   
  Partials          0          0          

Powered by Codecov. Last update 8ef870a...f48d76f

@pmairoldi
Copy link
Collaborator

Could you add tests for this change?

@liuxuan30
Copy link
Member

under what situation it is NaN?

@liuxuan30
Copy link
Member

liuxuan30 commented Nov 18, 2016

root caused in #1737 comments. Due to 32 bit double min. merging.

@liuxuan30 liuxuan30 merged commit e51bfb0 into ChartsOrg:master Nov 18, 2016
@Selficide Selficide deleted the fix-decimal-crash-in-chartutils branch November 18, 2016 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants