-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Charts Icons Support Swift3 [Dub #629, #624, #1261] #1793
Conversation
…consEnabled() and var iconOffset
…a property and dataset allows
Okay, how do I fix these checks to be green? On my mac everything is built successfully for all platforms (iOS, OSX, tvOS) |
@AnatolyRosencrantz update the test cases? |
I've already generated those test images, put them to appropriate Tests/ReferenceImages_64/ folders (which is the only place I've found other test images). By some reason FBSnapshotTestCase was saving them under /Library/Developer/Xcode/DerivedData by default, btw. |
Really looking forward to this! :) |
Guys, does somebody know where travis expects FBSnapshotTestCase's images to be? There are dozen of folders called "Tests" in project's directory |
You don't have to move anything anywhere. When you record the tests they images will be placed in the right place. The setting for the path is an environment variable in the test scheme. |
56a8712
to
fbba515
Compare
any update on this ?? |
@farazhaider88 fighting with Travis to accept pr |
Current coverage is 18.80% (diff: 28.11%)@@ master #1793 diff @@
==========================================
Files 124 124
Lines 14083 14239 +156
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2629 2677 +48
- Misses 11454 11562 +108
Partials 0 0
|
all pass! @danielgindi seems we can put this higher priority? |
# Conflicts: # Charts.xcodeproj/project.pbxproj
@Anders123fr, fixed that incorrect misplacement. So in case of Pie chart |
This is getting better, and it seems like people are enjoying it :-) |
Why can't I see the file changed when I download this project from master? thanks |
@AntonioFM92 cuz it was not merged to master yet |
This just saved me a ton of work (was going to implement this my self), thanks a ton! One question, though: Is it possible in a pie chart view to render the icons below the label text so that the two don't overlap? As was said before, at the moment, changing the offset draws the labels further outside rather than below. |
…(in addition to distance from center)
@MrMage pushed a fix. Now iconsOffset for Pie and Radar charts represents (vertical offset; distance form center offset).
|
@danielgindi still not a time? :) |
Is this not going to be in the main release? |
I believe they are busy :( |
Yeah time is precious, but the good news is I'm working on this one :-) |
There are a few coding style inconsistencies, but I'm not going to bug you about them right now; It's in the best interest of the users that we don't introduce any extra delays for this right now. I'm actually surprised on how clean and little code this PR is, which means you understand how the library works. |
There are a few bugs to polish though |
I have updated my pods - pod update Charts but I can't find any property or method related to icon such as drawIconsEnabled |
This pull request hasn't been released yet. To use non-released features on the
|
Any advice I have tried pod update and also askeilboe's advice but still cannot see this? I am using swift. |
Finally, implemented Icons (Nodal Image) feature for all charts and updated to Swift3.
I've chosen to store image in data parameter of ChartDataEntry to allow icons to be specified per-value (example of use: to sign personal records in running application). Dataset can specify if it will draw icons and customise offset from default placement. IconOffset is CGSize, but for radial Radar and Pie only height value matters — as distance from centre.
ChartBaseDataSet, IChartDataSet:
ChartUtils:
All xxxChartRenderers:
BarChartDataEntry:
Demos: included star image to project, for stacked bar, pie, line, candle stick, bubble, bar and horizontal bar added Toggle Icon button and star to be drawn.