Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements in BalloonMarker.swift #2393

Merged
merged 2 commits into from
May 26, 2017
Merged

Minor improvements in BalloonMarker.swift #2393

merged 2 commits into from
May 26, 2017

Conversation

valeriyvan
Copy link
Contributor

Getting rid of not needed String-NSString bridging

Getting rid of not needed String-NSString bridging
@codecov-io
Copy link

codecov-io commented Apr 26, 2017

Codecov Report

Merging #2393 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
- Coverage   19.66%   19.65%   -0.01%     
==========================================
  Files         112      112              
  Lines       13712    13714       +2     
==========================================
  Hits         2696     2696              
- Misses      11016    11018       +2
Impacted Files Coverage Δ
Source/Charts/Charts/ChartViewBase.swift 24.23% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5288c25...0570233. Read the comment docs.

{
return
}
guard let label = label else { return }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing more indent here, please double check

@liuxuan30 liuxuan30 merged commit b007b02 into ChartsOrg:master May 26, 2017
PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
Minor improvements in BalloonMarker.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants