Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix turning off drag in X and Y axes separately. #2949

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

maciejtrybilo
Copy link
Contributor

Unfortunately 3c083f3 broke my change.

The use case when the problem appears is when a chart is embedded in a scroll view. Disabling y axis dragging should enable the scroll view to be used for vertical scrolling with the finger on the chart.

The change in this PR is required for this to work.

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #2949 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
- Coverage   19.64%   19.63%   -0.01%     
==========================================
  Files         113      113              
  Lines       13792    13794       +2     
==========================================
  Hits         2709     2709              
- Misses      11083    11085       +2
Impacted Files Coverage Δ
Source/Charts/Charts/BarLineChartViewBase.swift 22.85% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbdaa6...37c8a77. Read the comment docs.

@liuxuan30
Copy link
Member

@danielgindi seems positive?

@maciejtrybilo
Copy link
Contributor Author

@liuxuan30 @danielgindi Any more thoughts on this?

@liuxuan30
Copy link
Member

liuxuan30 commented Dec 5, 2017

sorry, been busy with work and reviewing those swift refinement. I am positive on your PR, though not tested. I will try later(some fixes shall be included in the next release)

@liuxuan30 liuxuan30 merged commit 60829b3 into ChartsOrg:master Dec 5, 2017
@maciejtrybilo
Copy link
Contributor Author

Thanks! No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants