fix the error title for demo #3528
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3528 +/- ##
=======================================
Coverage 29.94% 29.94%
=======================================
Files 118 118
Lines 13793 13793
=======================================
Hits 4130 4130
Misses 9663 9663Continue to review full report at Codecov.
|
| @@ -28,7 +28,7 @@ - (void)viewDidLoad | |||
| { | |||
| [super viewDidLoad]; | |||
|
|
|||
| self.title = @"Pie Bar Chart"; | |||
There was a problem hiding this comment.
@petester42 @jjatie need some advise on the name. Pie Bar Chart is ok or kind of typo ?
There was a problem hiding this comment.
IMO
"Pie Chart" is better.
There was a problem hiding this comment.
I would agree. It's more clear.
| @@ -28,7 +28,7 @@ - (void)viewDidLoad | |||
| { | |||
| [super viewDidLoad]; | |||
|
|
|||
| self.title = @"Pie Bar Chart"; | |||
There was a problem hiding this comment.
I would agree. It's more clear.
| @@ -21,7 +21,7 @@ class PieChartViewController: DemoBaseViewController { | |||
| super.viewDidLoad() | |||
|
|
|||
| // Do any additional setup after loading the view. | |||
| self.title = "Half Pie Bar Chart" | |||
| self.title = "Pie Chart" | |||
There was a problem hiding this comment.
I think we should keep the 'half' word?
There was a problem hiding this comment.
I think that the "Pie Chart" is correct since the controller name is "PieChartViewController".
BTW, I have fixed the title to "Half Pie Chart" from "Half Pie Bar Chart" for "HalfPieChartViewController.swift"
yangasahi
force-pushed
the
demo_title_fix
branch
from
04593d2
to
5d9860f
Compare
| @@ -21,7 +21,7 @@ class PieChartViewController: DemoBaseViewController { | |||
| super.viewDidLoad() | |||
|
|
|||
| // Do any additional setup after loading the view. | |||
| self.title = "Half Pie Bar Chart" | |||
| self.title = "Pie Chart" | |||
|
Thanks! |
No description provided.