fix issue #3662

[Michael-Du]

Issue Link 🔗

#3662

When i used CombinedChartView, CandleStickChartRenderer never draw dataSet

Implementation Details 🚧

Testing Details 🔍

I tested in example demo and my project

[codecov-io]

Codecov Report

Merging #3664 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
+ Coverage   31.06%   31.06%   +<.01%     
==========================================
  Files         114      114              
  Lines       10465    10464       -1     
==========================================
  Hits         3251     3251              
+ Misses       7214     7213       -1

Impacted Files	Coverage Δ
...ce/Charts/Renderers/CandleStickChartRenderer.swift	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5087a04...26dfe03. Read the comment docs.

[liuxuan30]

I remember it's used to be working. I need to check old commits what broke it.

[liuxuan30]

@mathewa6 can you see this? Need you double check, we are good to merge this fix. But not sure why you cast dataProvider to candleView in the first place.

[mathewa6]

@liuxuan30 Sorry about this: it is a mistake on my side. And it is safe to merge with regards to accessibility.

The reason the cast existed is that at one point, I was attempting to use a single inherited createAccessibilityElement() method. However, for some charts like Bar Charts, we needed to access the valueFormatter for axes labels, hence I used a cast on the container. There was no reason for it to be a guard or for it to exist in CandleStick charts.

[liuxuan30]

sure, thanks everyone!